Improve mission phase checks #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasiero
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Looks good as is. One thing that comes to mind is that this (and the old code) assumes the user only supplies valid scans. e.g. 20000a would return Reactivation_2014 despite being during hibernation. Do we care about users doing bad searches? Should we add something at line 250 along the lines of elif scan<44XXX: return none?
|
I think we should leave it as is, there are so many edge cases where the user can put in invalid scan-ids. Attempting to enumerate them all would make this code even more complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more explicit where scan ids are converted to mission phases. This is a bit fuzzy around reactivation year boundaries, but is FAR more accurate.
This has been tested by loading every single field of view through all phases through 2023 december, verifying that it returns the correct phase except near year boundaries where it may be off by a year, but still return "Reactivation_".
It is precisely correct for non-reactivation phases.